Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo for vertical federated learning #9103

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Apr 26, 2023

Moved the current nvflare demo under horizontal.

@rongou
Copy link
Contributor Author

rongou commented Apr 26, 2023

@trivialfis

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Out of curiosity,is there any difficulty for running it on the CI?

@rongou
Copy link
Contributor Author

rongou commented Apr 27, 2023

For the horizontal one, it's probably not that hard since it only uses the small mushroom dataset. But for the vertical one we are downloading Higgs which is probably too big for CI.

@hcho3 should we try to run the demo (at least the horizontal one) on the CI? I think it would involve installing nvflare in the python environment.

@trivialfis
Copy link
Member

We can probably add a CPU test later. At the moment, I think it's quite difficult to setup the dependencies using only conda. (Correct me if I'm wrong). I will wait for conda to get rid of the autotools build for protobuf.

@trivialfis trivialfis merged commit fb94126 into dmlc:master Apr 28, 2023
@rongou rongou deleted the demo-vertical-federated branch September 25, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants